Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearStore not work #1180

Closed
kannerban opened this issue Aug 29, 2024 · 2 comments · Fixed by #1181
Closed

clearStore not work #1180

kannerban opened this issue Aug 29, 2024 · 2 comments · Fixed by #1181
Labels

Comments

@kannerban
Copy link

clearStore() items are not resetting correctly when I use this method. When I select an option, it adds a new item instead of resetting to the initial state.
Screenshot 2024-08-29 111807

@kannerban kannerban added the bug label Aug 29, 2024
@Xon
Copy link
Collaborator

Xon commented Aug 29, 2024

It is actually a bug in the refresh which it is preserving previous selections, and the setChoiceByValue method not respecting the single selection when restoring the initial configuration

@Xon Xon linked a pull request Aug 29, 2024 that will close this issue
@Xon
Copy link
Collaborator

Xon commented Aug 29, 2024

It was clearStore. It wasn't pruning the item list UI after the performance fixes around very large number of times.

I've got a fix, just want to confirm all the end-to-end tests still pass, including the new one to rest the form reset functionality

@Xon Xon closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants