Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the auto-update profile by default. #128

Open
dotnvo opened this issue Jan 18, 2025 · 0 comments
Open

Consider removing the auto-update profile by default. #128

dotnvo opened this issue Jan 18, 2025 · 0 comments

Comments

@dotnvo
Copy link

dotnvo commented Jan 18, 2025

https://github.com/ChrisTitusTech/powershell-profile/blob/main/Microsoft.PowerShell_profile.ps1#L54-L80

Perhaps I'm off-base here, but when reading your profile I came across something that I thought was pretty awesome at first - but then I started thinking about how it might be abused.

I'm referring to the auto-update of the profile; While I definitely can see the value in automatically grabbing a new updated profile and installing it behind the scenes, there's security implications in this process, not to mention just general concerns that some users may not understand. This is a pretty solid profile - built on oh my posh so, so I imagine it's pretty popular. Unfortunately, this means if you were targeted in a hack and someone took over your GitHub account, they could easily distribute malicious code via this profile and simply launching PowerShell would potentially load this code on end user systems. Just something to consider. I know you provide steps on how to make it your own but in my experience some people may just install the default and not change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant