Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support / checking for long lines in reference fasta #19

Open
roblanf opened this issue Mar 3, 2017 · 1 comment
Open

Support / checking for long lines in reference fasta #19

roblanf opened this issue Mar 3, 2017 · 1 comment
Milestone

Comments

@roblanf
Copy link

roblanf commented Mar 3, 2017

Love the software. But it took me noticing a few odd things in my results before I went and read all the docs carefully, and then I found this listed (very clearly) in open issues on the github README:

The length of a line in a input FASTA file must not exceed 4096 bp.

It would be great if you could fix this, so that it would read any length of input lines from a reference.fa file. Failing that, checking whether the reference will be truncated and spitting an error should presumably be just a couple of lines of code.

Right now, I find the behaviour a little troubling: NextGenMap ran perfectly well on my data, and it wasn't until I was looking at the output that I realised something must be up (a lot of the genome had 0 mapping quality). To me, this has the potential to cause inferential issues to users (admittedly, users who don't look carefully at their output... but we know they exist) who aren't aware the issue exists. A simple error & quit, or just fixing the issue (even by reformatting the reference.fa to the format you need) should both be pretty simple, and might help avoid issues for users.

@philres philres added this to the v0.5.4 milestone Mar 3, 2017
@philres
Copy link
Member

philres commented Mar 3, 2017

Hi Rob!

Thank you very much for the feedback! Yes you are right, truncating the reference without a warning or an error is definitely not the optimal way to handle this. We will address this in the next release!

Best,
Philipp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants