OnAccessExcludePath fail if there is a subdirectory

[tchernomax]

Describe the bug

Imagine the following hierarchy:

/a/
  b/
    c/
  x/

OnAccessIncludePath /a
OnAccessExcludePath /a/b

clamonacc will first "register" /a and all it's subdirectory (b, b/c, x).
From what I understand clamonacc will have buckets:

• /a
• /a/b
• /a/b/c
• /a/x

Since #1314 it will call onas_ht_rm_hierarchy on all "bucket" matching /a/b:

• /a/b → ok, (it will also delete /a/b/c)
• /a/b/c → fail (this path is already deleted)

It is possible to bypass the problem by using OnAccessExcludePath ^/a/b$.

Off-topic note: OnAccessExcludePath regexp or not isn't "dynamic", what I mean is that if the exclude path isn't present at the clamonacc start, but is created afterward → the exclusion isn't taken into account (I don't know if it's explained somewhere in the documentation)

[micahsnyder]

Am I correct in thinking this bug is only in the main branch right now (i.e. will only affect 1.5.0, unless we fix before the stable release)?

I haven't tested it yet. I missed triaging this when you first submitted it. What happens when it fails because the path is already deleted? Does clamonacc fail to load or just throw a warning or error message?

Good point about it not being dynamic. I agree it seems like the exclusion should be checked before each scan.

TBH I feel like the ExcludePath option should also be checked in the same way by clamonacc.