Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing / incorrect language in pipeline.conf #6

Open
ShivanKaul opened this issue Dec 11, 2017 · 0 comments
Open

Confusing / incorrect language in pipeline.conf #6

ShivanKaul opened this issue Dec 11, 2017 · 0 comments

Comments

@ShivanKaul
Copy link

In pipeline.conf:

#[gRPCDialout]
...
# encap = gpb
# Encapsulation pushed by client: gpb, gpbkv, gpbcompact.
# As of 6.1.1 release, we support gpb (which is a common
# header used to carry compact and k/v gpb), and we default
# to gpb. In older releases, it might be necessary to configure
# compact or k/v.

So is gpb the only encap supported? What does

"is a common header used to carry compact and k/v gpb"

mean? Is gpb kv supported or not?

In older releases, it might be necessary to configure compact or k/v.

There are no official releases on GitHub, and this is the only source code available. If gpbkv is not supported here and is supported in an older release, is it possible to get access to an older release?


[inspector]
stage = xport_output
#
# Module type: tap is only supported in xport_output stage currently.
#
type = tap
...
# encoding = json
#
# Options: json_events | gpb, gpb_kv. If format is a binary format, or
# not supported for input encoding in use (gpb if proto is available,
# gpbk/v or JSON), we fall back to hex. Default is JSON

I'm not sure I understand json_events | gpb, gpb_kv. Was that supposed to be json_events | gpb | gpb_kv?
I tried using gpb_kv, it is not a valid choice - the accepted token is gpbkv.

If format is a binary format, or
not supported for input encoding in use (gpb if proto is available,
gpbk/v or JSON), we fall back to hex

gpbkv / JSON are not supported for any input encoding?
Should that have read "gpb if proto is unavailable"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant