TAN-3815 - Add community monitor survey BE (OLD) #10313
Open
+588
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jamesspeake
commented
Feb 12, 2025
There was a problem hiding this comment.
Note: Just an example of the default form override at the moment
jamesspeake
commented
Feb 18, 2025
| @@ -72,6 +72,7 @@ class ProjectPhaseStarted < Notification | |||
|
|
|||
| def self.make_notifications_on(activity) | |||
| phase = activity.item | |||
| return [] unless phase.project.published? | |||
There was a problem hiding this comment.
Could have just used unless phase.project.hidden? for this use case but felt there was actually no need to notify on these unless the project was published - draft or archived has no real use
jamesspeake
commented
Feb 18, 2025
Comment on lines
+52
to
+57
| hidden_project = create(:project, internal_role: 'community_monitor', admin_publication_attributes: { publication_status: 'hidden' }) | ||
| expect(status).to eq(200) | ||
| json_response = json_parse(response_body) | ||
| expect(json_response[:data].size).to eq 10 | ||
| expect(json_response[:data].map { |d| d.dig(:relationships, :publication, :data, :type) }.count('project')).to eq 8 | ||
| expect(json_response[:data].map { |d| d.dig(:relationships, :publication, :data, :type) }.count('folder')).to eq 2 | ||
| expect(response_data.size).to eq 10 | ||
| expect(response_data.map { |d| d.dig(:relationships, :publication, :data, :type) }.count('project')).to eq 8 | ||
| expect(response_data.map { |d| d.dig(:relationships, :publication, :data, :type) }.count('folder')).to eq 2 | ||
| expect(response_data.pluck(:id)).not_to include(hidden_project.admin_publication.id) |
There was a problem hiding this comment.
This is the only actual test change. The rest of the changes are only changes to use the response_data helper
jamesspeake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in a nutshell:
internal_role: 'community_monitoron project andpublication_status: hiddenon admin publicationnative_surveyphase on this project with new attributenative_survey_methodwhich will work in a similar way to voting_method to make the small tweaks to the participation method we needcommunity_monitorwhich also stores the project ID for this projectChangelog
Technical