-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAN-3873] Support new sentiment_linear_scale custom field #10357
base: master
Are you sure you want to change the base?
[TAN-3873] Support new sentiment_linear_scale custom field #10357
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few really minor comments
...tom_fields/spec/acceptance/idea_custom_fields/phase_context/update_all_native_survey_spec.rb
Outdated
Show resolved
Hide resolved
@@ -1564,7 +1564,8 @@ CREATE TABLE public.phases ( | |||
manual_votes_count integer DEFAULT 0 NOT NULL, | |||
manual_voters_amount integer, | |||
manual_voters_last_updated_by_id uuid, | |||
manual_voters_last_updated_at timestamp(6) without time zone | |||
manual_voters_last_updated_at timestamp(6) without time zone, | |||
native_survey_method character varying | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesspeake Do I need to be concerned about the changes in this file? 🤔 Aside from the ask_follow_up, they're not related to my other changes, but doing a migrate/rebuild doesn't seem to change this file for me locally..
…3874-support-sentiment-question-form-builder
…thub.com:CitizenLabDotCo/citizenlab into TAN-3874-support-sentiment-question-form-builder
…AN-3875-support-sentiment-question-front-office
…ment-question-front-office [TAN-3875] Support sentiment_linear_scale field in front office
…ment-question-form-builder [TAN-3874] Support new sentiment question in form builder
….com:CitizenLabDotCo/citizenlab into TAN-3873-be-new-sentiment-linear-scale-field
All code in this PR has been code-reviewed ✔️
Description: