Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAN-3873] Support new sentiment_linear_scale custom field #10357

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

amanda-anderson
Copy link
Contributor

@amanda-anderson amanda-anderson commented Feb 17, 2025

All code in this PR has been code-reviewed ✔️

Description:

  • Support new sentiment_linear_scale custom field type in BE, form builder + front office.
  • Support for new results view will be added later on during the tandem.

Copy link

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Feb 18, 2025

Warnings
⚠️

The changelog is empty. What should I put in the changelog?

Messages
📖 Notion issue: TAN-3873
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against 89370a9

@amanda-anderson amanda-anderson requested review from jamesspeake and removed request for jamesspeake February 18, 2025 15:41
Copy link
Contributor

@jamesspeake jamesspeake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few really minor comments

@@ -1564,7 +1564,8 @@ CREATE TABLE public.phases (
manual_votes_count integer DEFAULT 0 NOT NULL,
manual_voters_amount integer,
manual_voters_last_updated_by_id uuid,
manual_voters_last_updated_at timestamp(6) without time zone
manual_voters_last_updated_at timestamp(6) without time zone,
native_survey_method character varying
);
Copy link
Contributor Author

@amanda-anderson amanda-anderson Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesspeake Do I need to be concerned about the changes in this file? 🤔 Aside from the ask_follow_up, they're not related to my other changes, but doing a migrate/rebuild doesn't seem to change this file for me locally..

amanda-anderson and others added 8 commits February 26, 2025 09:33
…thub.com:CitizenLabDotCo/citizenlab into TAN-3874-support-sentiment-question-form-builder
…ment-question-front-office

[TAN-3875] Support sentiment_linear_scale field in front office
…ment-question-form-builder

[TAN-3874] Support new sentiment question in form builder
@amanda-anderson amanda-anderson changed the title [TAN-3873] Support new sentiment_linear_scale custom field type in BE [TAN-3873] Support new sentiment_linear_scale custom field Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants