Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAN-3906 - User fields in survey form #10391

Draft
wants to merge 24 commits into
base: TAN-3961-refactor-domicile
Choose a base branch
from
Draft

TAN-3906 - User fields in survey form #10391

wants to merge 24 commits into from
+262 −15

Conversation

jamesspeake
Copy link
Contributor

@jamesspeake jamesspeake commented Feb 19, 2025 •
edited
Loading

How it works

  • New feature flag: user_fields_in_survey - always disabled for now
  • New attribute on phase: user_fields_in_form. Can only be set when the feature flag is on. When toggled on this:
    • Adds all user fields configured in access rights for the phase to a new page at the end of the survey
    • Enables permission custom fields for 'everyone' access rights
    • Removes the user custom fields from the user signup flow
    • If a user is logged in then the fields will pre-populate with the values from their profile

The way this works is by

  • User custom fields are merged with the Idea custom fields in CustomFieldsService and we change some attributes to return them as Idea custom fields. They then behave just as Idea custom fields.
  • Responses get saved in the idea record, but user field responses are prefixed with u_ and if a user is logged in it will also update their profile
  • This allows user custom fields to be used on anonymous submissions too and has the advantage that all data related to surveys is fixed in time
  • Because we have a clear way of identifying user fields in the survey, in the future it should be relatively easy to pull together demographics from both users and survey submissions if we want

Changelog

Added

  • Toggle to allow user fields to be asked as part of the survey form instead of part of registration

@jamesspeake jamesspeake added this to the Community Monitor milestone Feb 19, 2025
@notion-workspace Notion Workspace
Copy link

Allow user demographic fields to be embedded in the survey form

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Feb 19, 2025 •
edited
Loading

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-3906
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against faf5329

jamesspeake and others added 18 commits February 21, 2025 10:05
@jamesspeake
[TAN-3906] Added phase setting and feature flag for user fields in form
77f6679
@jamesspeake
[TAN-3906] Fix for user requirements service
b6efea7
@jamesspeake
[TAN-3906] Fixed saving of user fields to idea
13054ee
@jamesspeake
[TAN-3906] Update user profile if user fields used in survey
8385894
@jamesspeake
[TAN-3906] Removed specific survey_fields method
8c648e8
@jamesspeake
[TAN-3906] Use dropdown layout for user fields
d68d71e
@jamesspeake
[TAN-3906] Optional/required working
768f97c
@jamesspeake
[TAN-3906] Changed variable names
1257909
@jamesspeake
[TAN-3906] Got domicile working
2188215
@jamesspeake
[TAN-3906] Change endpage logic when user_page is present
25eca55
@jamesspeake
Merge branch 'master' into TAN-3906-user-fields-in-survey-form
c419474 
# Conflicts:
#	back/config/schemas/settings.schema.json.erb
#	back/engines/commercial/multi_tenancy/db/seeds/tenants.rb
#	front/app/api/app_configuration/types.ts
@jamesspeake
[TAN-3906] Added text values into messages
0aeab03
Translations updated by CI (extract-intl)
e2eac10
@jamesspeake
[TAN-3906] Rubocop fixes
9696fe9
@jamesspeake
Merge remote-tracking branch 'origin/TAN-3906-user-fields-in-survey-f…
eece2df 
…orm' into TAN-3906-user-fields-in-survey-form
@jamesspeake
[TAN-3906] Fixed anonymous submissions
bef89e0
@jamesspeake
[TAN-3906] Spacing
5622881
@jamesspeake
Merge branch 'TAN-3961-refactor-domicile' into TAN-3906-user-fields-i…
5135884 
…n-survey-form

# Conflicts:
#	back/app/services/json_schema_generator_service.rb
#	back/app/services/survey_results_generator_service.rb
#	back/spec/services/user_json_schema_generator_service_spec.rb
@jamesspeake jamesspeake changed the base branch from master to TAN-3961-refactor-domicile February 26, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Community Monitor
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesspeake @cl-dev-bot