[TAN-3958] Small tweaks to VisibleTextMultilocs service (renamed) #10435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jinjagit
changed the title
sebastienhoorens
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisibleTextMultilocs, to help highlight the fact that we do not extract alt-text multilocs fromImageMultilocnodes<h3>...</h3>tags intoAccordianMultilocnode title multilocs, for consistency with the tags wrapping text in all the other extracted mutlilocs (maybe this is useful information when processing further, e.g. with an LLM)To be honest, I'm not very sure about these changes, and things may evolve differently as I develop the related functionality.
Changelog
Technical
VisibleTextMultilocsservice (renamed)