Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple Pre-shattering quests have incorrect questbits #1581

Open
jewelkinggames opened this issue Jan 24, 2025 · 4 comments
Open

[BUG] Multiple Pre-shattering quests have incorrect questbits #1581

jewelkinggames opened this issue Jan 24, 2025 · 4 comments

Comments

@jewelkinggames
Copy link

1. Current Behavior

1.1. Description

during the transition into the shattering several quests somehow had their associated questbit changed, causing them to return as completed = false in cataclsym game builds, preventing them from counting towards achievement progress, or rewarding the transmog appearances they should

Affected IDs: 368,459,765,894,896,900,901,902,3124,3921,3922,5157,5245,13097,

1.2. How to Reproduce

      {Describe the steps to reproduce the particular bug, in detail:
       1. login to character who completed "A New Plague" ID 368 prior to the launch of cataclsym classic
       2. /run print(C_QuestLog.IsQuestFlaggedCompleted(368))
       3. observe "false" being returned

1.3 Source Material

{Video, Posts, etc..}

2. Expected Behavior

2.1. Description

run command should have returned "true"

2.2 Source Material

@Kethryllia
Copy link
Collaborator

Kethryllia commented Jan 24, 2025

Thanks for the report!

I checked the first several quests in both Cataclysm and War Within Data, and the quest bits were identical. Looking at the changelogs, this change took place in the original Cataclysm. It looks like we picked up the post-Cata quest bits when we were setting up Cataclysm data for Cata Classic.

@jewelkinggames
Copy link
Author

Thanks for the report!

I checked the first several quests in both Cataclysm and War Within Data, and the quest bits were identical. Looking at the changelogs, this change took place in the original Cataclysm. It looks like we picked up the post-Cata quest bits when we were setting up Cataclysm data for Cata Classic.

Indeed, unfortunately over 100 pre Cataclsym quests had their questbits changed in the patch from wotlk to cata, many were just straight up reused, these 14 I listed in this report are just the ones that the ID was no longer used after the cataclsym update,

unfortunately for the other 90 or so orphaned questbits, the quest ID they were originally associated with is now used by a completely new quest :(

P.S, Could you check on the Classic Era report section as well? I tossed in 3 reports for non-functional quests there 2 weeks ago, would mean a lot if they could be reviewed =)

@Kethryllia
Copy link
Collaborator

Indeed, unfortunately over 100 pre Cataclsym quests had their questbits changed in the patch from wotlk to cata, many were just straight up reused, these 14 I listed in this report are just the ones that the ID was no longer used after the cataclsym update,

Since it's accurate to the Cataclysm data, it's unfortunately technically not a bug. :(

P.S, Could you check on the Classic Era report section as well? I tossed in 3 reports for non-functional quests there 2 weeks ago, would mean a lot if they could be reviewed =)

Speaking for myself, I'm very busy for the next few few days, so I can't get to them right now. If you could, please bump those github issues on Wednesday and we'll take a look then.

@jewelkinggames
Copy link
Author

Indeed, unfortunately over 100 pre Cataclsym quests had their questbits changed in the patch from wotlk to cata, many were just straight up reused, these 14 I listed in this report are just the ones that the ID was no longer used after the cataclsym update,

Since it's accurate to the Cataclysm data, it's unfortunately technically not a bug. :(

P.S, Could you check on the Classic Era report section as well? I tossed in 3 reports for non-functional quests there 2 weeks ago, would mean a lot if they could be reviewed =)

Speaking for myself, I'm very busy for the next few few days, so I can't get to them right now. If you could, please bump those github issues on Wednesday and we'll take a look then.

gotcha okay, smidge confused on that but I appreciate the reply,

I will make sure to bump the other ones on Wednesday! (they are already at the top of the page so Im not sure how that will help but I will do it haha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants