Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Calling GetItemStats on items with stats from auras prints a warning message #23

Open
raethkcj opened this issue Jan 27, 2025 · 0 comments
Labels
Items Related SoD Bug Enough evidence achieved and bug is considered major

Comments

@raethkcj
Copy link

1. Current Behavior

1.1. Description

Many items in Classic have stats provided through a passive aura attached to the item through ItemEffect, rather than having the stats on the item itself. When the API function GetItemStats is called on one of these items, a warning message is printed in the console.

1.2. How to Reproduce

  1. /console enable
  2. Press `, the default keybinding to open the console, observe current messages, then close again
  3. /dump GetItemStats("\124cff0070dd\124Hitem:12784::::::::60:::::\124h[Arcanite Reaper]\124h\124r")
  4. Open the console again and observe

CGast - CGItemStatsSummary::ParseSpellRec is being called for spellID: 15816, effect aura: 99, which is wrong
CGast - CGItemStatsSummary::ParseSpellRec is being called for spellID: 15816, effect aura: 124, which is wrong

1.3 Source Material

Image

2. Expected Behavior

2.1. Description

Calling GetItemStats on a valid item shouldn't result in warning messages.

@raethkcj raethkcj added Items Related SoD Bug Enough evidence achieved and bug is considered major labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items Related SoD Bug Enough evidence achieved and bug is considered major
Projects
None yet
Development

No branches or pull requests

1 participant