Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "copy-from" to keep variant data. #79531

Open
nemesis688 opened this issue Feb 4, 2025 · 0 comments
Open

Allow "copy-from" to keep variant data. #79531

nemesis688 opened this issue Feb 4, 2025 · 0 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist <Suggestion / Discussion> Talk it out before implementing

Comments

@nemesis688
Copy link

Is your feature request related to a problem? Please describe.

"copy-from" Doesn't seem to preserve "variants" data. When using "copy-from" to make tweaks for a mod the various variants get wiped out if you don't include the entire list. Which, in effect, replaces the list. Making targeted changes a bit harder and less obvious as whats an intentional change and what isn't.

For example, I wanted to edit the "pocket_data" of the smartphone case to allow Aftershocks 'Atomic Smartphone' to fit. Having to include the entire list makes the tweak less targeted and can cause issues if the list of variants gets expanded or reduced.

I can see the utility when you are using "copy-from" for a new item to not automatically bring in the variants data with it but that could be accomplished by having a variant list of one like how several firearms are currently set up.

Additionally the "extend" field does not work with variants data so if someone wants to add a new variant of an item they have to include and overwrite the whole list to do so.

Solution you would like.

I would appreciate it if the code governing "copy-from" could be tweaked to allow the variants data to be preserved. It would also be nice if "extend" could interact with variant data.

Describe alternatives you have considered.

Simply not making the request and keep including more data than needed in targeted tweaks.

Additional context

No response

@nemesis688 nemesis688 added the <Suggestion / Discussion> Talk it out before implementing label Feb 4, 2025
@Maleclypse Maleclypse added the (S2 - Confirmed) Bug that's been confirmed to exist label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants