Map-related items not always initializing properly

[ShnitzelX2]

Describe the bug

Sometimes, map caches will spawn without PRESERVE_SPAWN_LOC data.

This is because map::add_item, which adds the relevant data, is not always called when items are added to the map. Example: when monster item drops are put into corpses, or when smartphones are put into smartphone cases. Some screenshots:

stack of (all!) map caches from a pile of zombie corpses, note lack of location data

and again from 100 civilian_phones, about 8 of 65 of them:

Attach save file

N/A, easily reproducible

Steps to reproduce

1. Kill a bunch of generic zombies (alternatively, spawn civilian_phones item group)
2. Download their phones' contents onto one device
3. Note lack of location data in map caches

Expected behavior

Ideally, these items should have their location data initialized when they are added to the map under any circumstance.

I'm just adding this issue as a reminder, it's not a high-priority bug because maps will use the player's position by default if no spawn location data is found. I think it's actually more concerning that map::add_item doesn't cover every case of an item being added to the map.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.5371 (22H2)
• Game Version: cdda-experimental-2025-02-03-2150-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response