Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to unify the behavior of insert_item_activity_actor whether to put the item into the nested pocket? #80032

Open
typeryougishiki opened this issue Mar 6, 2025 · 0 comments
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@typeryougishiki
Copy link
Contributor

Is your feature request related to a problem? Please describe.

insert_item_activity_actor will put items with count_by_charges()==true into nested pockets, but will not put other items into nested pockets. Is this some kind of purposeful design? Does this need to be unified?

Solution you would like.

If uniform behavior is desired, add an option to insert_item_activity_actor to allow all items to be put into nested pockets or not.

Describe alternatives you have considered.

No response

Additional context

No response

@typeryougishiki typeryougishiki added the <Suggestion / Discussion> Talk it out before implementing label Mar 6, 2025
@typeryougishiki typeryougishiki changed the title Is it necessary to unify the behavior of insert_item_activity_actor whether to put the item into the pocket? Is it necessary to unify the behavior of insert_item_activity_actor whether to put the item into the nested pocket? Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

1 participant