Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider type hierarchy refactor to simplify diagnostic methods #895

Open
kmdeck opened this issue Oct 29, 2024 · 0 comments
Open

Consider type hierarchy refactor to simplify diagnostic methods #895

kmdeck opened this issue Oct 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kmdeck
Copy link
Member

kmdeck commented Oct 29, 2024

We have many shared diagnostics between SoilCanopyModel and the LandModel. This leads to shared methods, which then dispatch off of an argument being of type Union{SoilCanopyModel, LandModel}.

It might be good to update our type hierarchy with a new abstract type - something like AbstractSoilCanopyModel, where we would have both SoilCanopyModel <: AbstractSoilCanopyModel and LandModel <: AbstractSoilCanopyModel. Maybe even AbstractIntegratedModel or AbstractComplexModel, but these values are specific to having canopy + soil so we might want to be more specific in the naming.

@kmdeck kmdeck added the enhancement New feature or request label Oct 29, 2024
@kmdeck kmdeck mentioned this issue Oct 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant