Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates diagnostic for computing mixed layer depth #296

Merged
merged 26 commits into from
Dec 16, 2024

Conversation

glwagner
Copy link
Member

The diagnostic is based on a buoyancy differential. I used a default 3e-5, which is the recommended potential density difference 0.03 (see for example Treguier et al 2023) divided by a reference density ~1e3.

We should add a test and also limit by the static column depth from Oceananigans, @simone-silvestri maybe you can look this over.

I also added an example which is not literated, but we could consider literating it.

@glwagner
Copy link
Member Author

Hmm looks like this may depend on #284 so let's merge that first

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a193aee) to head (211cdfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Diagnostics/mixed_layer_depth.jl 0.00% 47 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #296   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1951    1961   +10     
=====================================
- Misses      1951    1961   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glwagner glwagner merged commit 6a87267 into main Dec 16, 2024
19 of 20 checks passed
@glwagner glwagner deleted the glw/mixed-layer-depth branch December 16, 2024 19:45
@navidcy
Copy link
Collaborator

navidcy commented Dec 23, 2024

I also added an example which is not literated, but we could consider literating it.

That's great. But you also deleted the example that was literated. And then #312 put the non-literated example (that uses GLMakie and sliders and what not) in the docs and made all doc builds fail onwards.

@navidcy
Copy link
Collaborator

navidcy commented Dec 23, 2024

My only point was that if the literated file is deleted then we should remove it from make.jl otherwise it might trigger mistakes as in #312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants