-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates diagnostic for computing mixed layer depth #296
Conversation
Hmm looks like this may depend on #284 so let's merge that first |
…aOcean.jl into glw/mixed-layer-depth
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1951 1961 +10
=====================================
- Misses 1951 1961 +10 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Simone Silvestri <[email protected]>
That's great. But you also deleted the example that was literated. And then #312 put the non-literated example (that uses GLMakie and sliders and what not) in the docs and made all doc builds fail onwards. |
My only point was that if the literated file is deleted then we should remove it from |
The diagnostic is based on a buoyancy differential. I used a default 3e-5, which is the recommended potential density difference 0.03 (see for example Treguier et al 2023) divided by a reference density ~1e3.
We should add a test and also limit by the static column depth from Oceananigans, @simone-silvestri maybe you can look this over.
I also added an example which is not literated, but we could consider literating it.