Fix ECCOrestoring show method #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NoraLoose if you can confirm that the issue is resolved with this PR it'd be great! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1983 1983
=====================================
Misses 1983 1983 ☔ View full report in Codecov by Sentry. |
navidcy
commented
Dec 21, 2024
| @@ -340,7 +344,7 @@ function Base.show(io::IO, p::ECCORestoring) | |||
| "├── restoring dataset: ", summary(p.field_time_series.backend.metadata), '\n', | |||
| "├── restoring rate: ", p.rate, '\n', | |||
| "├── mask: ", summary(p.mask), '\n', | |||
| "└── grid: ", summary(p.grid)) | |||
| "└── grid: ", summary(p.native_grid)) | |||
There was a problem hiding this comment.
this is the bug fix
simone-silvestri
approved these changes
Dec 22, 2024
|
Thanks for the bug fix @navidcy! I can confirm that this resolved the issue. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #310
(Also took the opportunity to fix the docstring rendering for ECCORestoring)