ECCO's metadata_url and urls both add a / between the url's path and filename

[navidcy]

The metadata_url at:

ClimaOcean.jl/src/DataWrangling/ECCO/ECCO_metadata.jl

Lines 150 to 151 in 7ddb30b

	metadata_url(prefix, m::ECCOMetadata{<:Any, <:ECCO2Daily}) = prefix * "/" * short_name(m) * "/" * metadata_filename(m)
	metadata_url(prefix, m::ECCOMetadata{<:Any, <:ECCO2Monthly}) = prefix * "/" * short_name(m) * "/" * metadata_filename(m)

add a / after the prefix. But the prefix is inferred from the urls at:

ClimaOcean.jl/src/DataWrangling/ECCO/ECCO_metadata.jl

Lines 199 to 202 in 7ddb30b

	# URLs for the ECCO datasets specific to each version
	urls(::ECCOMetadata{<:Any, <:ECCO2Monthly}) = "https://ecco.jpl.nasa.gov/drive/files/ECCO2/cube92_latlon_quart_90S90N/monthly/"
	urls(::ECCOMetadata{<:Any, <:ECCO2Daily}) = "https://ecco.jpl.nasa.gov/drive/files/ECCO2/cube92_latlon_quart_90S90N/daily/"
	urls(::ECCOMetadata{<:Any, <:ECCO4Monthly}) = "https://ecco.jpl.nasa.gov/drive/files/Version4/Release4/interp_monthly/"

which also include a / at the end.

This results in a double //.

Which one should we keep; does it matter for elsewhere?

[glwagner]

Does this cause the downloads to fail? (eg is this a bug or a typo?)

[navidcy]

Downloading was failing for me; that's how I discovered this.

[glwagner]

Huh, wonder how the tests passed then