Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use & Confirm Relative Lengths in Our CSS (All of It!) #378

Open
8 tasks
courte opened this issue Apr 3, 2015 · 0 comments
Open
8 tasks

Use & Confirm Relative Lengths in Our CSS (All of It!) #378

courte opened this issue Apr 3, 2015 · 0 comments

Comments

@courte
Copy link
Member

courte commented Apr 3, 2015

Description
Many of our stylesheets use absolute lengths (pixels) instead of relative ones (percentages, ems). It leads to odd styling in weird places and frustrating development.

Ask
Where it makes sense, please transition from using px to using percentages or ems in our stylesheets.

To Do
Adjust relative lengths for:

  • assets/stylesheets/code_good_day.scss
  • events.css.scss
  • footer.css.scss
  • header.css.scss
  • home.css.scss
  • index.css.scss
  • navigation.css.scss
  • projects.css.scss

Additional Info
This has the capacity to subtly muck up a lot of things in the view. Please:

  • only work with one view or stylesheet per pull request;
  • search for selector repetition in other stylesheets and views to confirm you're only impacting one view;
  • share before and after screenshots in your pull request; and
  • use (Foundation 4 standards)[http://foundation.zurb.com/docs/v/4.3.2/] when necessary.

Note: Anyone who takes part of this on is seriously heroic and should be applauded. Immediately. 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant