Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation issues #17

Open
joergreichert opened this issue May 17, 2021 · 6 comments
Open

Fix validation issues #17

joergreichert opened this issue May 17, 2021 · 6 comments

Comments

@joergreichert
Copy link
Contributor

Just discovered the validator today: node ./validation/testcenter-validator.js

For Berlin and Hessen there are still some issues (already fixed the issues for Leipzig and Duesseldorf)
validation_issues.txt

@johnjohndoe
Copy link
Collaborator

Please note that the validation script in the Wo ist Markt? project has been improved lately. You might want to pick the relevant code changes.

@joergreichert
Copy link
Contributor Author

Synced with https://github.com/wo-ist-markt/wo-ist-markt.github.io
Still validation issues for Berlin and Hessen
ouput.txt

@johnjohndoe
Copy link
Collaborator

johnjohndoe commented May 30, 2021

Did you run npm test on the project? There is a bunch of lint warnings which might cause other errors.

I think the project should have automatic CI checks as it is running for the Wo ist Markt? repository. What do you think about this?

@joergreichert
Copy link
Contributor Author

I've fix the lint issues besides validation/testcenter-validator.js: line 600, col 19, 'URL' is not defined. 👍 for automatic CI checks. So we need to integrate the netlify.toml and the rollup dependency for this, right?

@johnjohndoe
Copy link
Collaborator

I addressed the URL issue in #23. With that you should be able to run the updated validation script.

@johnjohndoe
Copy link
Collaborator

For automatic checks Wo ist Markt? is using Travis CI. A minimal .travis.yml configuration (copied from here) would be:

language: node_js

node_js: # Read version from .nvmrc

install:
  - npm install

script:
  - npm test
  - npm build

You can of course use any other CI provider such as GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants