Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update number-flow.mdx #33

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update number-flow.mdx #33

merged 1 commit into from
Jan 6, 2025

Conversation

barvian
Copy link
Contributor

@barvian barvian commented Jan 6, 2025

Description

This PR updates the NumberFlow docs after a small breaking change I made yesterday to reduce the bundle size. I try not to do breaking changes often 😅

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

None, though it came up on X this morning.

Mobile & Desktop Screenshots/Recordings

image image

Steps to QA

  1. Open /docs/components/number-flow locally
  2. Scroll down to Props section

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

* Remove continuous prop
* Add link to full docs
Copy link

vercel bot commented Jan 6, 2025

@barvian is attempting to deploy a commit to the Codehagen Team on Vercel.

A member of the Team first needs to authorize it.

@Codehagen Codehagen self-requested a review January 6, 2025 17:50
Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100 % correct.

@Codehagen
Copy link
Owner

The man himself, thanks for the PR ✨

@Codehagen Codehagen merged commit 115f458 into Codehagen:main Jan 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants