Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality enhancement - Integrations::Discord::Service #959

Open
wrspada02 opened this issue Sep 23, 2024 · 0 comments
Open

Code quality enhancement - Integrations::Discord::Service #959

wrspada02 opened this issue Sep 23, 2024 · 0 comments

Comments

@wrspada02
Copy link
Contributor

APIs (#send and .send) are inconsistent, and the #send method includes an environment check (Rails.env.development?) and makes direct external HTTP requests, which should be encapsulated.
Similar issues apply to Integrations::Slack::Service and Integrations::Mattermost::Service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wrspada02