Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How best_practices.md is being used? #1288

Open
mattyan1726 opened this issue Oct 11, 2024 · 4 comments
Open

How best_practices.md is being used? #1288

mattyan1726 opened this issue Oct 11, 2024 · 4 comments
Labels

Comments

@mattyan1726
Copy link

Hello, I am trying to understand how best_practices.md is being used in this document section
Is this relevant_best_practices here retrieving info from best_practices.md file and add to the LLM context? I am not seeing where best_practices.md is being used in the code.
Thank you!

@mattyan1726
Copy link
Author

Also, I hope to understand the effect of adding instructions in the content of best_practices section in .pr_agent.toml vs extra_instructions in pr_review section in .pr_agent.toml. Thank you so much!

@mrT23
Copy link
Collaborator

mrT23 commented Oct 12, 2024

best_practice file is a feature of pr-agent pro (there is a "💎" sign).
So you wont find the code using it in the open source

@mattyan1726
Copy link
Author

@mrT23 thank you for the answer!
We subscribing to the pro version of pr-agent, and we are wondering if we contribute to the open source code (standard version), will that have an impact on the pro version? Or the pro version is a different forked project and contributing to the open source code will have no impact?

Also, I am observing review quality being different for e.g. java code vs IOS code. If I understand correctly, the default model was finetuned with 25k PR's, and I am wondering what these 25k PR's are composed of (distribution of PR's across programming languages). It also mentions that the pro version can configure it to use solely claude or gpt model here, are these models finetuned as well? What are the models we can experiment with in the config file other than 'claude-3-5-sonnet' and 'gpt-4o'.

Thanks again

@mrT23
Copy link
Collaborator

mrT23 commented Oct 17, 2024

@mrT23 mrT23 added the answered label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants