[Bug]: Progress bar falls back when updating

[Gaojianli]

Affected Version

1.82.9

Bug Behavior

Progress bar falls back when updating. See the screenshot

Expected Behavior

Progress bar just increase.

Steps to reproduce

Upgrade to1.8.114

Related Issues

No response

Screenshot(s)

Collapse.2025-01-14.23-38-19.mp4

Additional Information

No response

[neon-nyan]

Hi there,
This might be related to update issue that happened on: #642 and should have been fixed in later releases (1.82.10 and later).
Try follow the instruction Here to force-update your launcher to the latest version.

[Gaojianli]

Thanks for your advice. The launcher has been successfully updated after the progress reach 100%, I am just reporting a gui bug here :⁠-⁠).

…

--------------原始邮件-------------- 发件人："Kemal Setya Adhi ***@***.***>; 发送时间：2025年1月14日(星期二) 晚上11:53 收件人："CollapseLauncher/Collapse" ***@***.***>; 抄送："高渐离 ***@***.***>;"Author ***@***.***>; 主题：Re: [CollapseLauncher/Collapse] [Bug]: Progress bar falls back when updating (Issue #667) ----------------------------------- Hi there, This might be related to update issue that happened on: #642 and should have been fixed in later releases. Try follow the instruction Here to force-update your launcher to the latest version. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[bagusnl]

Corresponding code

Collapse/CollapseLauncher/XAMLs/Updater/UpdaterWindow.xaml.cs

Lines 125 to 142 in 2a44755

	private void FallbackCDNUtil_DownloadProgress(object sender, DownloadEvent e)
	{
	double speed = e.SizeDownloaded / CurrentStopwatch.Elapsed.TotalSeconds;
	TimeSpan timeLeft = ToTimeSpanRemain(e.SizeToBeDownloaded, e.SizeDownloaded, speed);
	DispatcherQueue?.TryEnqueue(() =>
	{
	progressBar.IsIndeterminate = false;
	progressBar.Value = e.ProgressPercentage;
	ActivityStatus.Text = string.Format(Lang._UpdatePage.UpdateStatus3, 1, 1);
	ActivitySubStatus.Text =
	$"{SummarizeSizeSimple(e.SizeDownloaded)} / {SummarizeSizeSimple(e.SizeToBeDownloaded)}";
	SpeedStatus.Text =
	string.Format(Lang._Misc.SpeedPerSec, SummarizeSizeSimple(speed));
	TimeEstimation.Text = string.Format(Lang._Misc.TimeRemainHMSFormat, timeLeft);
	});
	}

Fix proposal

+  private double _progressLastValue {get; set;} = 0;
   private void FallbackCDNUtil_DownloadProgress(object sender, DownloadEvent e) 
   { 
       double speed      = e.SizeDownloaded / CurrentStopwatch.Elapsed.TotalSeconds; 
       TimeSpan timeLeft = ToTimeSpanRemain(e.SizeToBeDownloaded, e.SizeDownloaded, speed); 
    
       DispatcherQueue?.TryEnqueue(() => 
                                   { 
+                                      var progressPercentage = e.ProgressPercentage;
                                       progressBar.IsIndeterminate = false; 
+                                      if (progressPercentage > _progressLastValue)
+                                      {
+                                          progressBar.Value    = progressPercentage; 
+                                          _progressLastValue   = progressPercentage;
+                                      }
-                                      progressBar.Value = e.ProgressPercentage; 
                                       ActivityStatus.Text = string.Format(Lang._UpdatePage.UpdateStatus3, 1, 1); 
                                       ActivitySubStatus.Text = 
                                           $"{SummarizeSizeSimple(e.SizeDownloaded)} / {SummarizeSizeSimple(e.SizeToBeDownloaded)}"; 
    
                                       SpeedStatus.Text = 
                                           string.Format(Lang._Misc.SpeedPerSec, SummarizeSizeSimple(speed)); 
                                       TimeEstimation.Text = string.Format(Lang._Misc.TimeRemainHMSFormat, timeLeft); 
                                   }); 
   } 

Practically force the progress bar to never go back in value
or something like that, don't have access to my PC atm