From 99f1338b94e5ca7143aac0887525733ae13bdcd1 Mon Sep 17 00:00:00 2001
From: kyzooghost <73516204+kyzooghost@users.noreply.github.com>
Date: Thu, 23 Jan 2025 18:44:42 +1100
Subject: [PATCH] [Fix] CI warnings (#590)

* update actions/cache to 4.2.0 as per deprecation warning

* checkout before setup-go in prover-testing.yml

* point setup-go to prover/go.sum

* empty commit to rerun prover test after go action cache

* fix cache hit error in prover-test workflow

* apply golang caching changes to run-smc-tests

* fix bad change to cache-docker-images
---
 .github/workflows/cache-docker-images.yml   |  2 +-
 .github/workflows/coordinator-testing.yml   |  2 +-
 .github/workflows/prover-testing.yml        | 22 +++++++++++----------
 .github/workflows/reuse-run-e2e-tests.yml   |  2 +-
 .github/workflows/run-smc-tests.yml         |  6 +++---
 .github/workflows/staterecovery-testing.yml |  2 +-
 6 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/cache-docker-images.yml b/.github/workflows/cache-docker-images.yml
index 482fb7496..83d0a197f 100644
--- a/.github/workflows/cache-docker-images.yml
+++ b/.github/workflows/cache-docker-images.yml
@@ -70,7 +70,7 @@ jobs:
           done
       - name: Cache common docker images
         continue-on-error: true
-        uses: actions/cache/save@v4.0.2
+        uses: actions/cache/save@v4.2.0
         with:
           path: ~/docker-images
           key: cached-images
diff --git a/.github/workflows/coordinator-testing.yml b/.github/workflows/coordinator-testing.yml
index c3f1a68d2..0df306ec5 100644
--- a/.github/workflows/coordinator-testing.yml
+++ b/.github/workflows/coordinator-testing.yml
@@ -42,7 +42,7 @@ jobs:
         uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
       - name: Restore cached images
         id: restore-cached-images
-        uses: actions/cache/restore@v4.0.2
+        uses: actions/cache/restore@v4.2.0
         with:
           path: ~/docker-images
           key: cached-images
diff --git a/.github/workflows/prover-testing.yml b/.github/workflows/prover-testing.yml
index da0d8b742..9d1d6003f 100644
--- a/.github/workflows/prover-testing.yml
+++ b/.github/workflows/prover-testing.yml
@@ -14,18 +14,19 @@ jobs:
     runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
     name: Prover static check
     steps:
-    - name: install Go
-      uses: actions/setup-go@v5
-      with:
-        go-version: 1.23.x
     - name: checkout code
       uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - uses: actions/cache@v4
+    - name: install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.23.x
+        cache-dependency-path: |
+              prover/go.sum
+    - uses: actions/cache@v4.2.0
       with:
         path: |
-          ~/go/pkg/mod
           ~/.cache/go-build
           ~/Library/Caches/go-build
           %LocalAppData%\go-build
@@ -59,16 +60,17 @@ jobs:
     needs:
       - staticcheck
     steps:
+    - name: checkout code
+      uses: actions/checkout@v4
     - name: install Go
       uses: actions/setup-go@v5
       with:
         go-version: ${{ matrix.go-version }}
-    - name: checkout code
-      uses: actions/checkout@v4
-    - uses: actions/cache@v4
+        cache-dependency-path: |
+              prover/go.sum
+    - uses: actions/cache@v4.2.0
       with:
         path: |
-          ~/go/pkg/mod
           ~/.cache/go-build
           ~/Library/Caches/go-build
           %LocalAppData%\go-build
diff --git a/.github/workflows/reuse-run-e2e-tests.yml b/.github/workflows/reuse-run-e2e-tests.yml
index 789f53e28..66fa2141f 100644
--- a/.github/workflows/reuse-run-e2e-tests.yml
+++ b/.github/workflows/reuse-run-e2e-tests.yml
@@ -99,7 +99,7 @@ jobs:
           chmod -R a+w tmp/local/traces/v2/conflated
       - name: Restore cached images
         id: restore-cached-images
-        uses: actions/cache/restore@v4.0.2
+        uses: actions/cache/restore@v4.2.0
         with:
           path: ~/docker-images
           key: cached-images
diff --git a/.github/workflows/run-smc-tests.yml b/.github/workflows/run-smc-tests.yml
index dbb07d838..582bb8a26 100644
--- a/.github/workflows/run-smc-tests.yml
+++ b/.github/workflows/run-smc-tests.yml
@@ -44,12 +44,12 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version: 1.23.x
-          cache: false
+          cache-dependency-path: |
+                prover/go.sum
 
-      - uses: actions/cache@v4
+      - uses: actions/cache@v4.2.0
         with:
           path: |
-            ~/go/pkg/mod
             ~/.cache/go-build
             ~/Library/Caches/go-build
             %LocalAppData%\go-build
diff --git a/.github/workflows/staterecovery-testing.yml b/.github/workflows/staterecovery-testing.yml
index 861ff495a..43100ccc5 100644
--- a/.github/workflows/staterecovery-testing.yml
+++ b/.github/workflows/staterecovery-testing.yml
@@ -43,7 +43,7 @@ jobs:
         uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
       - name: Restore cached images
         id: restore-cached-images
-        uses: actions/cache/restore@v4.0.2
+        uses: actions/cache/restore@v4.2.0
         with:
           path: ~/docker-images
           key: cached-images