It looks like the coordinator tests are failing now, please have a look and adjust accordingly.

see: https://github.com/Consensys/linea-monorepo/actions/runs/11687214785/job/32693999670?pr=278

It looks like the coordinator tests are failing now, please have a look and adjust accordingly.

see: https://github.com/Consensys/linea-monorepo/actions/runs/11687214785/job/32693999670?pr=278

I've added a fix in this commit.

Please note that I haven’t yet been able to run the coordinator tests locally. I’ve raised an issue regarding this setup difficulty here.

@nadeemb53 The coordinator test is failed again and should be easily fixed by replacing sendWithRetry() return type with EthSendTransaction, btw for running the unit tests locally, you could open the repo in your IDE (preferably IntelliJ) and then run ./gradlew -V coordinator:app:buildNeeded, just like what we did in this github workflow file. Similarily, in the same file, you could also see how we run coordinator integration tests.

@nadeemb53 FYI, we have a class called AsyncRetryer which could potentially be used for this case, the caveat is that it assumes the action return type is async and needs to pass in an vertx instance.

All committers have signed the CLA.

Hi @nadeemb53 my apologies for the conflicts, I was not aware of this PR so in one of my PRs I fixed the issue because it was breaking the CI on my PR.

The issue was that when we ran all tests in parallel (can be even different JVM processes), some tests may randomly be assigned the same whale account: Imagine that we have 4 tests sharing the whale account, and they send 4 competing transactions with the same nonce, 3 of them will get an error. These 3 remaining tests just need to retry sending the same transaction with a new nonce until it succeeds (the least lucky one will retry 3 times). Although the proposed solution would work just fine, the current solution with a simple retry works just fine, no need for extra logic for transaction replacement with gasPrice increase.

Since the problem seems to be solved I think we can close this PR?

makes sense, i'll close this