Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatasourceRequest class #85

Open
VargBurz opened this issue Aug 1, 2019 · 2 comments
Open

DatasourceRequest class #85

VargBurz opened this issue Aug 1, 2019 · 2 comments
Assignees
@VargBurz

Comments

@VargBurz
Copy link
Member

VargBurz commented Aug 1, 2019

We should add DatasourceRequest class and move function queryByMetric into this class.
Possible, function getGrafanaUrl must be DatasourceRequest method.
@VargBurz VargBurz self-assigned this Aug 1, 2019
@VargBurz VargBurz mentioned this issue Aug 1, 2019
Closed
@jonyrock
Copy link
Member

jonyrock commented Aug 1, 2019

Why do you want to do it? What is the purpose?

@VargBurz
Copy link
Member Author

VargBurz commented Aug 9, 2019

Class will have some state(metric, grafana url, api key), that can define bounds condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VargBurz VargBurz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DatasourceRequest class #85 CorpGlory/grafana-datasource-kit
2 participants
@jonyrock @VargBurz