Generic interfaces on examples #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 42 42
Lines 2916 2916
=======================================
Hits 2479 2479
Misses 437 437 ☔ View full report in Codecov by Sentry. |
hashedone
approved these changes
Jul 22, 2024
jawoznia
reviewed
Jul 24, 2024
It seems like it's needed for now or else it won't compile. @jawoznia and @kulikthebird think it might be a bug in Sylvia |
abefernan
force-pushed
the
examples-generic-ifaces
branch
2 times, most recently
from
c9dd755 to
12f010f
Compare
jawoznia
requested changes
Aug 6, 2024
abefernan
force-pushed
the
examples-generic-ifaces
branch
from
12f010f to
7b4a585
Compare
abefernan
force-pushed
the
examples-generic-ifaces
branch
from
7b4a585 to
4e0bafd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #399.
This PR deals with the "Interfaces" part of the issue above.
It also makes the affected contracts and tests use
cosmwasm_std::Emptyfor their different implementations of the now generic interfaces.