Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Performance Tuning options #7

Open
dapug opened this issue Dec 4, 2017 · 1 comment
Open

Consider Performance Tuning options #7

dapug opened this issue Dec 4, 2017 · 1 comment
Assignees

Comments

@dapug
Copy link

dapug commented Dec 4, 2017

Marcin, this is a great project. Nice work!

You might consider adding/exposing perf options. See here:
https://docs.particular.net/persistence/azure-storage/performance-tuning
https://docs.microsoft.com/en-us/azure/storage/common/storage-performance-checklist

You could set this through the constructor, or perhaps expose a method that can be called, like:

    public void OptimizeNetwork(int connectionLimit)
    {
        var queueServicePoint = ServicePointManager.FindServicePoint(account.QueueEndpoint);
        queueServicePoint.Expect100Continue = false;
        queueServicePoint.UseNagleAlgorithm = false;
        queueServicePoint.ConnectionLimit = connectionLimit;

        var tableServicePoint = ServicePointManager.FindServicePoint(account.TableEndpoint);
        tableServicePoint.Expect100Continue = false;
        tableServicePoint.UseNagleAlgorithm = false;
        tableServicePoint.ConnectionLimit = connectionLimit;

        var blobServicePoint = ServicePointManager.FindServicePoint(account.BlobEndpoint);
        blobServicePoint.Expect100Continue = false;
        // blobServicePoint.UseNagleAlgorithm = false; // Not needed for blob
        blobServicePoint.ConnectionLimit = connectionLimit;
    }

I don't know if more granularity would be needed, but you get the idea. I recommend an optional constructor that can indicate the desire for setting this up, and input the connection limit. I can submit a PR if you'd like, but if this is interesting to you at all, this is probably sufficient for you to add in yourself.

@Crokus
Copy link
Owner

Crokus commented Jan 2, 2018

Glad you like it David.

Sorry for late reply but recently I was not that active on my OSS projects but this will improve in 2018 :)

Good input and I'll try to add that in the next couple of days. Thanks!

@Crokus Crokus self-assigned this Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants