Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unified_inventory armor tab #69

Open
Kyuhisan opened this issue Apr 7, 2023 · 3 comments
Open

Fix unified_inventory armor tab #69

Kyuhisan opened this issue Apr 7, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Kyuhisan
Copy link
Contributor

Kyuhisan commented Apr 7, 2023

When equipping armor pieces which textures overlap in the preview window the matter you put them in matters since preview is rendered in the order grid window is set up. Therefore moving armor pieces around changes the preview render as seen in the images below.

HByNo7d
WYI2BK9

Armor is rendered based on the order seen in the image below where the ones that come next will overlap in the preview over the previous armor pieces.

eMgKrRs

There are 2 solutions:

  • Either make a grid that can accept certain items only in certain slots like the way minecraft does (helmet socket, chestplate socket..)
  • Or determine an order in which these armor pieces are previewed that logically makes sense (1st leggings, 2nd chestplate, 3rd boots, 4th helmet, etc...)

Realistically only issue so far is with leggings as they should go under chestplate and boots so always rendering leggings on top would be good too.

@Kyuhisan Kyuhisan self-assigned this Apr 7, 2023
@SeqSEE SeqSEE added bug Something isn't working enhancement New feature or request labels Apr 9, 2023
@squidicuzz
Copy link
Contributor

I think we can add a draw/z-index priority to the armor for display in the slots.. I'll look into that.

@squidicuzz squidicuzz self-assigned this Apr 13, 2023
@squidicuzz squidicuzz added this to the Beta Release milestone Apr 13, 2023
@squidicuzz
Copy link
Contributor

This was done, ya?

@squidicuzz
Copy link
Contributor

Nevermind-- We still need to do the slot priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants