Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new CI issue (ubsan) #998

Open
Cyan4973 opened this issue Jan 18, 2025 · 1 comment
Open

new CI issue (ubsan) #998

Cyan4973 opened this issue Jan 18, 2025 · 1 comment
Assignees

Comments

@Cyan4973
Copy link
Owner

This was triggered recently, likely as a consequence of Github updating ubuntu-latest to 24.04 :

./xxhsum -bi0
xxhsum 0.8.3 by Yann Collet
compiled as 64-bit x86 autoVec (AVX2 detected) little endian with Clang 18.1.3 (1ubuntu1)
cli/xsum_sanity_check.c:360:15: runtime error: call to function XXH3_update through pointer to incorrect function type 'XXH_errorcode (*)(struct XXH3_state_s *, const void *, unsigned long)'
/home/cyan/dev/xxhash/github/./xxhash.h:6611: note: XXH3_update defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior cli/xsum_sanity_check.c:360:15
make[1]: *** [Makefile:216: check] Error 1
@Cyan4973 Cyan4973 self-assigned this Jan 18, 2025
@Cyan4973
Copy link
Owner Author

Cyan4973 commented Jan 18, 2025

This is weird, and I don't know how to fix that.

This code in xsum_sanity_check.c never invokes XXH3_update() directly, since it is an internal function,

but rather the public symbols XXH3_64bits_update() and XXH3_128bits_update(),
both of which have a correct prototype corresponding to the function pointer definition ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant