Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop accum when context is disabled #41

Open
santaluciar opened this issue Jan 4, 2024 · 0 comments
Open

stop accum when context is disabled #41

santaluciar opened this issue Jan 4, 2024 · 0 comments
Assignees

Comments

@santaluciar
Copy link

Hi,

Hope you are all well and wish you a great new year.
I noticed the following:

[jit.time] keeps accumulating also when the context is disabled.
Therefore, if the output value of [jit.time] is 32.15748 at the moment that I disable the context (a.k.a. jit.world), re-enabling it after few seconds shows that [jit.time] starts outputting from a value higher than 32.15748, because it actually only stopped outputing, it did not stop accumulating.
I tried a workaround by sending an on/off message (bolean) to the [jit.time] as a consequence of turning on or off the context, and this still doesn't work. It looks like as soon as I turn off the context, the [jit.time] starts its counting without output and, while being off. Also, while the context is off [jit.time] doens't listen to a turn off message, I tried but when I re-nable the context, the output value of [jit.time] is nevertheless higher.

it is some time that I noticed this issue but only now it is becoming for me more and more of a bottleneck, as I am rendering images offline, without a costant fps because I am driving the render context with a custom "render bang" ==> the result is that I am downsampling the [jit.time] object.
Could this behaviour be improved, making the [jit.time] operations dependant on the actual render bang / fps?
I noticed now that the behaviour of [jit.time] ignores the context fps's setting.
This can be fixed by adjusting the [jit.time] speed according to the fps, but doesn't solve my issue.

Cheers,
Riccardo from Rotterdam

@robtherich robtherich self-assigned this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants