Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#142: phase: allow starting at non-zero phase #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lifflander
Copy link
Contributor

Fixes #142

@lifflander lifflander linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Contributor

@cwschilly cwschilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be more efficient to have a single function find both the number of phases n_phases and the minimum phase min_phase and store both as member variables of info. This would reduce the amount of times we have to loop through all ranks and phases.

@lifflander
Copy link
Contributor Author

I think it may be more efficient to have a single function find both the number of phases n_phases and the minimum phase min_phase and store both as member variables of info. This would reduce the amount of times we have to loop through all ranks and phases.

Getting the number of phases should be a constant time operation of just looking at the size of the phase_info for rank 0. The min_phase does cost more, but I agree that it should just happen once.

@lifflander
Copy link
Contributor Author

I have made min phase cached so it doesn't compute each time, which should improve performance.

Copy link
Contributor

@cwschilly cwschilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when phases don't start at zero
2 participants