From 2c57dd689a03ffc1cc19c55967d91dcb74bebd93 Mon Sep 17 00:00:00 2001 From: Peter Bjerg Lidegaard Date: Sat, 13 Jan 2024 22:47:59 +0100 Subject: [PATCH] - Added damage description to PO crit 2 system - Added damage description for all damage rolls - Added hit description for all hit rolls - Moved Weap vs armor to Standard rules. Removed the logic from PO rules --- ADnD_2E_Revised/2ESheet.html | 241 +++++++++--------- ADnD_2E_Revised/html/changelog.html | 2 + .../html/tabs/character-tab/weapons-tab.html | 82 ------ .../players-option-weapons-tab.html | 29 ++- .../weapons-tab/standard-weapons-tab.html | 104 +++++++- .../html/tabs/sheet-settings-tab.html | 2 +- ADnD_2E_Revised/javascript/sheetWorkers.js | 22 +- 7 files changed, 242 insertions(+), 240 deletions(-) diff --git a/ADnD_2E_Revised/2ESheet.html b/ADnD_2E_Revised/2ESheet.html index b486d458629f..d3a2273572bc 100644 --- a/ADnD_2E_Revised/2ESheet.html +++ b/ADnD_2E_Revised/2ESheet.html @@ -18,6 +18,8 @@

Changes in

  • Fixed cast time for Protection From Evil (Wizard) from 1 turn to +1 initiative modifier
  • Removed incorrect material components for Endure Cold/Endure Heat
  • Fixed spell description layout for Orison
  • +
  • Removed Weapon Type vs Armor type modifiers from the Hit roll under the Player's Option ruleset, as the Player's Option: Combat & Tactics has its own set of modifiers that differ from those given in the Player's Handbook
  • +
  • Weapon Type vs Armor type is now only visible under the Standard tab

  • @@ -1554,88 +1556,6 @@

    Rule set


    - -
    - Select armor opponent is wearing for bonuses/penalties - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
    Banded
    Mail
    |Brigandine|Chain
    Mail
    |Field
    Plate
    |Full
    Plate
    |Leather, Hide,
    & Padded
    |Plate Mail /
    Bronze Plate Mail
    |Ring
    Mail
    |Scale
    Mail
    |Splint
    Mail
    |Studded
    Leather
    - - - -
    -
    -
    @@ -1652,6 +1572,86 @@

    Rule set

    +
    + Select armor opponent is wearing for bonuses/penalties + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
    Banded
    Mail
    |Brigandine|Chain
    Mail
    |Field
    Plate
    |Full
    Plate
    |Leather, Hide,
    & Padded
    |Plate Mail /
    Bronze Plate Mail
    |Ring
    Mail
    |Scale
    Mail
    |Splint
    Mail
    |Studded
    Leather
    + + + +
    +
    Melee  Ranged
    @@ -1743,7 +1743,7 @@

    Rule set

    - + @@ -1751,7 +1751,7 @@

    Rule set

    - + @@ -1799,11 +1799,11 @@

    Melee Damage

    - - + + - - + + @@ -1921,7 +1921,7 @@

    Weapon Notes

    - + @@ -1929,7 +1929,7 @@

    Weapon Notes

    - + @@ -1979,11 +1979,11 @@

    Ammunition

    - - + + - - + + @@ -1996,6 +1996,7 @@

    Weapon Notes

    +
    Melee  Ranged
    @@ -2093,7 +2094,7 @@

    Weapon Notes

    - + @@ -2101,7 +2102,7 @@

    Weapon Notes

    - + @@ -2169,13 +2170,13 @@

    Melee Damage

    - - + + - - + + - + @@ -2303,7 +2304,7 @@

    Weapon Notes

    - + @@ -2311,7 +2312,7 @@

    Weapon Notes

    - + @@ -2395,13 +2396,13 @@

    Ammunition

    - - + + - - + + - + @@ -21917,7 +21918,7 @@

    Miscellaneous modifier popup on rolls


    @@ -71272,11 +71273,11 @@

    Monster Sheet specific

    ? values[prefix+'damsm'] : values[prefix+'daml']; let damageAdjFunc = (values) => [ - `(${values[prefix+'damadj']})`, - `({${values[prefix+'specialist-damage']},${values[prefix+'mastery-damage']}}kh1)`, - `((@{strengthdmg})*${values[prefix+'strbonus1']})`, - `((@{dexmissile})*${values[prefix+'dexbonus1']})`, - '(@{temp-damadj})', + `([[(@{strengthdmg})*${values[prefix+'strbonus1']}]] [Strength])`, + `([[(@{dexmissile})*${values[prefix+'dexbonus1']}]] [Dexterity])`, + `([[{${values[prefix+'specialist-damage']},${values[prefix+'mastery-damage']}}kh1]] [Proficiency])`, + `(${values[prefix+'damadj']} [Dmg Adj])`, + '(@{temp-damadj} [Temp buff])', '(@{misc-mod})' ].join('+'); @@ -71297,11 +71298,11 @@

    Monster Sheet specific

    ? values[prefix+'damsm2'] : values[prefix+'daml2']; let damageAdjFunc = (values) => [ - `(${values[prefix+'damadj2']})`, - `((@{strengthdmg})*${values[prefix+'strbonus3']})`, - `((@{dexmissile})*${values[prefix+'dexbonus3']})`, - `({${values[prefix+'specialist-damage2']},${values[prefix+'mastery-damage2']}}kh1)`, - '(@{temp-damadj})', + `([[(@{strengthdmg})*${values[prefix+'strbonus3']}]] [Strength])`, + `([[(@{dexmissile})*${values[prefix+'dexbonus3']}]] [Dexterity])`, + `([[{${values[prefix+'specialist-damage2']},${values[prefix+'mastery-damage2']}}kh1]] [Proficiency])`, + `(${values[prefix+'damadj2']} [Dmg Adj])`, + '(@{temp-damadj} [Temp buff])', '(@{misc-mod})' ].join('+'); @@ -71779,7 +71780,7 @@

    Monster Sheet specific

    rollBuilder.push(`multiplier=(Double)`); damage = `(${weaponDamage})*2`; } - rollBuilder.push(`damage=[[${damage}+[[${damageAdjFunc(values)}]] ]]`); + rollBuilder.push(`damage=[[${damage}+${damageAdjFunc(values)} ]]`); } if (errors.length > 0) diff --git a/ADnD_2E_Revised/html/changelog.html b/ADnD_2E_Revised/html/changelog.html index ee41eaceb888..a504261e495e 100644 --- a/ADnD_2E_Revised/html/changelog.html +++ b/ADnD_2E_Revised/html/changelog.html @@ -13,6 +13,8 @@

    Changes in

  • Fixed cast time for Protection From Evil (Wizard) from 1 turn to +1 initiative modifier
  • Removed incorrect material components for Endure Cold/Endure Heat
  • Fixed spell description layout for Orison
  • +
  • Removed Weapon Type vs Armor type modifiers from the Hit roll under the Player's Option ruleset, as the Player's Option: Combat & Tactics has its own set of modifiers that differ from those given in the Player's Handbook
  • +
  • Weapon Type vs Armor type is now only visible under the Standard tab

  • diff --git a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab.html b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab.html index 091eea7dffbf..c77547d57030 100644 --- a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab.html +++ b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab.html @@ -54,88 +54,6 @@

    Rule set


    - -
    - Select armor opponent is wearing for bonuses/penalties - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
    Banded
    Mail
    |Brigandine|Chain
    Mail
    |Field
    Plate
    |Full
    Plate
    |Leather, Hide,
    & Padded
    |Plate Mail /
    Bronze Plate Mail
    |Ring
    Mail
    |Scale
    Mail
    |Splint
    Mail
    |Studded
    Leather
    - - - -
    -
    -
    diff --git a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/players-option-weapons-tab.html b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/players-option-weapons-tab.html index 31522dc30a2c..95a700039c6f 100644 --- a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/players-option-weapons-tab.html +++ b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/players-option-weapons-tab.html @@ -1,4 +1,5 @@
    +
    Melee  Ranged
    @@ -96,7 +97,7 @@ - + @@ -104,7 +105,7 @@ - + @@ -172,13 +173,13 @@

    Melee Damage

    - - + + - - + + - + @@ -306,7 +307,7 @@

    Weapon Notes

    - + @@ -314,7 +315,7 @@

    Weapon Notes

    - + @@ -398,13 +399,13 @@

    Ammunition

    - - + + - - + + - + diff --git a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/standard-weapons-tab.html b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/standard-weapons-tab.html index 93d61744aa9c..db20fc005f59 100644 --- a/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/standard-weapons-tab.html +++ b/ADnD_2E_Revised/html/tabs/character-tab/weapons-tab/standard-weapons-tab.html @@ -1,4 +1,84 @@
    +
    + Select armor opponent is wearing for bonuses/penalties + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
    Banded
    Mail
    |Brigandine|Chain
    Mail
    |Field
    Plate
    |Full
    Plate
    |Leather, Hide,
    & Padded
    |Plate Mail /
    Bronze Plate Mail
    |Ring
    Mail
    |Scale
    Mail
    |Splint
    Mail
    |Studded
    Leather
    + + + +
    +
    Melee  Ranged
    @@ -90,7 +170,7 @@ - + @@ -98,7 +178,7 @@ - + @@ -146,11 +226,11 @@

    Melee Damage

    - - + + - - + + @@ -268,7 +348,7 @@

    Weapon Notes

    - + @@ -276,7 +356,7 @@

    Weapon Notes

    - + @@ -326,11 +406,11 @@

    Ammunition

    - - + + - - + + diff --git a/ADnD_2E_Revised/html/tabs/sheet-settings-tab.html b/ADnD_2E_Revised/html/tabs/sheet-settings-tab.html index 1631fa08217e..219ecc674677 100644 --- a/ADnD_2E_Revised/html/tabs/sheet-settings-tab.html +++ b/ADnD_2E_Revised/html/tabs/sheet-settings-tab.html @@ -196,7 +196,7 @@

    Miscellaneous modifier popup on rolls


    diff --git a/ADnD_2E_Revised/javascript/sheetWorkers.js b/ADnD_2E_Revised/javascript/sheetWorkers.js index 5a1fa8d7fa6e..645769b7d588 100644 --- a/ADnD_2E_Revised/javascript/sheetWorkers.js +++ b/ADnD_2E_Revised/javascript/sheetWorkers.js @@ -1939,11 +1939,11 @@ on('clicked:repeating_weapons-damage:crit2', function(eventInfo) { ? values[prefix+'damsm'] : values[prefix+'daml']; let damageAdjFunc = (values) => [ - `(${values[prefix+'damadj']})`, - `({${values[prefix+'specialist-damage']},${values[prefix+'mastery-damage']}}kh1)`, - `((@{strengthdmg})*${values[prefix+'strbonus1']})`, - `((@{dexmissile})*${values[prefix+'dexbonus1']})`, - '(@{temp-damadj})', + `([[(@{strengthdmg})*${values[prefix+'strbonus1']}]] [Strength])`, + `([[(@{dexmissile})*${values[prefix+'dexbonus1']}]] [Dexterity])`, + `([[{${values[prefix+'specialist-damage']},${values[prefix+'mastery-damage']}}kh1]] [Proficiency])`, + `(${values[prefix+'damadj']} [Dmg Adj])`, + '(@{temp-damadj} [Temp buff])', '(@{misc-mod})' ].join('+'); @@ -1964,11 +1964,11 @@ on('clicked:repeating_ammo:crit2', function (eventInfo) { ? values[prefix+'damsm2'] : values[prefix+'daml2']; let damageAdjFunc = (values) => [ - `(${values[prefix+'damadj2']})`, - `((@{strengthdmg})*${values[prefix+'strbonus3']})`, - `((@{dexmissile})*${values[prefix+'dexbonus3']})`, - `({${values[prefix+'specialist-damage2']},${values[prefix+'mastery-damage2']}}kh1)`, - '(@{temp-damadj})', + `([[(@{strengthdmg})*${values[prefix+'strbonus3']}]] [Strength])`, + `([[(@{dexmissile})*${values[prefix+'dexbonus3']}]] [Dexterity])`, + `([[{${values[prefix+'specialist-damage2']},${values[prefix+'mastery-damage2']}}kh1]] [Proficiency])`, + `(${values[prefix+'damadj2']} [Dmg Adj])`, + '(@{temp-damadj} [Temp buff])', '(@{misc-mod})' ].join('+'); @@ -2446,7 +2446,7 @@ function weaponPoCritTemplate(prefix, fields, nameFunc, baseDamageFunc, damageAd rollBuilder.push(`multiplier=(Double)`); damage = `(${weaponDamage})*2`; } - rollBuilder.push(`damage=[[${damage}+[[${damageAdjFunc(values)}]] ]]`); + rollBuilder.push(`damage=[[${damage}+${damageAdjFunc(values)} ]]`); } if (errors.length > 0)