Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LatinError exception in views that use volpiano display utilities #1423

Closed
dchiller opened this issue Apr 22, 2024 · 5 comments · Fixed by #1653
Closed

Handle LatinError exception in views that use volpiano display utilities #1423

dchiller opened this issue Apr 22, 2024 · 5 comments · Fixed by #1653
Assignees

Comments

@dchiller
Copy link
Contributor

DDMAL/volpiano-display-utilities#52 introduces the raising of LatinError when non-latin characters are passed in a word to be syllabified.

Views in CantusDB that use volpiano display utilities should handle this error. In particular, if entered text results in this error, users should be prompted to fix their text.

@annamorphism
Copy link

out of curiosity, what does this do for e.g. chants with Greek letters in them? Or that end in a hyphen, "this chant is a fragme-" ?

@dchiller
Copy link
Contributor Author

out of curiosity, what does this do for e.g. chants with Greek letters in them?

This would return a LatinError for a chant with greek letters in it. When non-Latin characters become valid on Cantus DB, we will have to update with new "syllabification" logics for any supported language + character set.

Or that end in a hyphen, "this chant is a fragme-" ?

This would be syllabified as "this chant is a frag-me-". In other words, this PR doesn't change anything about how hyphens are handled, as long as they are valid CantusDB strings.

@dchiller dchiller self-assigned this May 29, 2024
@annamorphism
Copy link

I'm getting repeated emails about bracketing mistakes resulting in 500 errors (admittedly, from the same user)--is this fix due to be on production soon?

@lucasmarchd01
Copy link
Contributor

@dchiller has this been resolved by #1487?

@dchiller
Copy link
Contributor Author

Let me check on this... I can't remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants