Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialVolume damping #226

Open
RaphaelGebhart opened this issue Feb 17, 2025 · 0 comments
Open

PartialVolume damping #226

RaphaelGebhart opened this issue Feb 17, 2025 · 0 comments

Comments

@RaphaelGebhart
Copy link
Contributor

RaphaelGebhart commented Feb 17, 2025

The definition/use of:

  • d = k_volume_damping*sqrt(abs(2*L/(V*max(density_derp_h, 1e-10)))) "Friction factor for coupled boundaries"
  • k_volume_damping "Damping factor multiplicator"
  • density_derp_h "Partial derivative of density by pressure at constant specific enthalpy"

in ThermofluidStream.Boundaries.Internal.PartialVolume is in my opinion not fully intuitive/not complete correct:

  • For an incompressible fluid + ThermofluidStream.Boundaries.Reservoir one can obtain k_volume_damping = sqrt(2)*D, with damping ratio D, i.e. k_volume_damping = sqrt(2) yields critical damping.
  • For an ideal gas, i.e. ThermofluidStream.Media.myMedia.Air.DryAirNasa, + ThermofluidStream.Boundaries.Volume one can obtain density_derp_h = cp/(R^2*T) = kappa/((kappa-1)*R*T) = kappa^2/((kappa-1)*a^2), with velocity of sound a, such that
    k_volume_damping = sqrt(2)*D*sqrt(density_derp_h/a^2) = sqrt(2)*D*kappa/(kappa-1), i.e. k_volume_damping = sqrt(2)*kappa/sqrt(kappa-1) yields critical damping.

Hence i would change:

  • k_volume_damping to damping ratio D
  • density_derp_h to velocity of sound a (partial derivative of pressure by density (commonly at constant specific entropy))

Of course we could also try to use Bessel filter or other filter characteristics.

And i would recommend to enhance the docu....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant