Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ideal gas check in ThermofluidStream/Processes/Turbine.mo #227

Open
marcelotomim opened this issue Feb 27, 2025 · 1 comment
Open

Ideal gas check in ThermofluidStream/Processes/Turbine.mo #227

marcelotomim opened this issue Feb 27, 2025 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@marcelotomim
Copy link

Dear Developers,

First of all, I would like to thank you for releasing such great library!
Regarding the topic of this issue, I am beginning to work with the ThermofluidStream library and I noticed in the line 28 of the ThermofluidStream/Processes/Turbine.mo model that Rout is not used to check the validity of the ideal gas assumption. It seems a sort of typo. I hope it helps.

Yours sincerely,
Marcelo Tomim
@RaphaelGebhart
Copy link
Contributor

Hi Marcelo,

we are glad to hear that you like the library.
Concerning your issue: Yes, you are right, it was already mentioned it in #175, and I hope we will be able to change it soon.

Best
Raphael

@tobolar tobolar added the duplicate This issue or pull request already exists label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobolar @marcelotomim @RaphaelGebhart