Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify noproj/cam2cam to Project OffBody Pixels #3602

Open
KrisBecker opened this issue Dec 14, 2019 · 7 comments
Open

Modify noproj/cam2cam to Project OffBody Pixels #3602

KrisBecker opened this issue Dec 14, 2019 · 7 comments
Labels
enhancement New feature or request Missions Issues which are a priority for missions

Comments

@KrisBecker
Copy link
Contributor

Description

Enhance noproj and cam2cam to essentially project all pixels in the focal plane - on and/or off the target body - to the output image. This has been extremely useful in detecting and tracking ejected particles from Bennu's surface.

Two program parameters were added - OFFBODY and OFFBODYTRIM.

OFFBODY=TRUE will project both target body and background pixels according to the distortion model. The NAVCAM camera has a rather prominent fisheye/barrel distortion. Applying noproj to these images computes the undistorted images preserving the entire image.

OFFBODYTRIM=TRUE will result in only the background pixel data to be projected into the output cube. The shape model is used to determine if the pixel is on or off the body. All pixels on the body are set to NULL in the output image so just the background data is preserved. This was a useful option since many of the NAVCAM images had to be overexposed. Projecting only the background pixels simplified detecting and processing the particles.

Default behavior is preserved with both parameters set to FALSE - the default.

Example

Here is the interface options of the two programs with the options.

[10]: noproj -h
FROM = Null
MATCH = Null
SPECS = Null
TO = Null
SOURCE = (*FROMMATCH, FROMINPUT, FROMUSER)
SUMMINGMODE = Null
INTERP = (NEARESTNEIGHBOR, BILINEAR, *CUBICCONVOLUTION)
SAMPEXP = 0.0
LINEEXP = 0.0
OFFBODY = FALSE
OFFBODYTRIM = FALSE

[11]: cam2cam -h
FROM = Null
MATCH = Null
TO = Null
REFBAND = Null
INTERP = (NEARESTNEIGHBOR, BILINEAR, *CUBICCONVOLUTION)
OFFBODY = FALSE
OFFBODYTRIM = FALSE

@jessemapel jessemapel added the Missions Issues which are a priority for missions label Dec 14, 2019
@jessemapel
Copy link
Contributor

Why this is important

Particle events and plumes are of scientific interest on various small bodies. On Bennu, particles have been found off the surface of the body and this modification was required to produce high quality data. On CG-67P, there are several surface plumes captured in imagery. This enhancement would help scientists study these plumes. I do not doubt that we will see further examples of "off-body" material in future missions to small and irregular bodies.

@rbeyer Would this also help with #3371?

@jessemapel jessemapel added the enhancement New feature or request label Dec 16, 2019
@ascbot
Copy link
Contributor

ascbot commented Sep 1, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

@ascbot ascbot added the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@jessemapel
Copy link
Contributor

This is still outstanding

@jessemapel jessemapel removed the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label May 26, 2021
@artmathgirl
Copy link
Contributor

Please reopen.

@acpaquette acpaquette reopened this Aug 1, 2024
artmathgirl added a commit to UA-LPL/ISIS3 that referenced this issue Aug 1, 2024
Addresses DOI-USGS#3602.
Added gtests to noproj to exercise OFFBODY and OFFBODYTRIM true/false parameters.
New tests use a cube stored in the ISIS test data osirisRexImages directory.
@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Aug 3, 2024
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Dec 8, 2024
artmathgirl added a commit to UA-LPL/ISIS3 that referenced this issue Jan 8, 2025
artmathgirl added a commit to UA-LPL/ISIS3 that referenced this issue Jan 9, 2025
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Jan 30, 2025
@artmathgirl
Copy link
Contributor

artmathgirl commented Jan 30, 2025 via email

@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Missions Issues which are a priority for missions
Projects
None yet
Development

No branches or pull requests

5 participants