Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Resolves #276

Closed
aeoranday opened this issue Oct 21, 2024 · 2 comments
Closed

Unhandled Resolves #276

aeoranday opened this issue Oct 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@aeoranday
Copy link
Member

While trying to run on NP02 from np04-srv-024, I get the following error:

AttributeError: 'NoneType' object has no attribute 'group'
           WARNING  core.py:50      click_shell.core:       Traceback (most recent call last):                                                                                                                                             
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/.venv/lib/python3.10/site-packages/click_shell/core.py", line 34, in invoke_                                                                                              
                        command.main(args=shlex.split(arg),                                                                                                                                                                                
                      File                                                                                                                                                                                                                 
                    "/cvmfs/dunedaq.opensciencegrid.org/spack/externals/ext-v2.1/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-12.1.0/py-click-8.1.7-rfosehaodhycdhjdju6ywpfiqy6gc6lm/lib/python3.10/site-packages/click/core.py",    
                    line 1078, in main                                                                                                                                                                                                     
                        rv = self.invoke(ctx)                                                                                                                                                                                              
                      File                                                                                                                                                                                                                 
                    "/cvmfs/dunedaq.opensciencegrid.org/spack/externals/ext-v2.1/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-12.1.0/py-click-8.1.7-rfosehaodhycdhjdju6ywpfiqy6gc6lm/lib/python3.10/site-packages/click/core.py",    
                    line 1434, in invoke                                                                                                                                                                                                   
                        return ctx.invoke(self.callback, **ctx.params)                                                                                                                                                                     
                      File                                                                                                                                                                                                                 
                    "/cvmfs/dunedaq.opensciencegrid.org/spack/externals/ext-v2.1/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-12.1.0/py-click-8.1.7-rfosehaodhycdhjdju6ywpfiqy6gc6lm/lib/python3.10/site-packages/click/core.py",    
                    line 783, in invoke                                                                                                                                                                                                    
                        return __callback(*args, **kwargs)                                                                                                                                                                                 
                      File                                                                                                                                                                                                                 
                    "/cvmfs/dunedaq.opensciencegrid.org/spack/externals/ext-v2.1/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-12.1.0/py-click-8.1.7-rfosehaodhycdhjdju6ywpfiqy6gc6lm/lib/python3.10/site-packages/click/decorators.py
                    ", line 45, in new_func                                                                                                                                                                                                
                        return f(get_current_context().obj, *args, **kwargs)                                                                                                                                                               
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/utils/utils.py", line 125, in wrapper                                                                                                          
                        ret = loop.run_until_complete(main_task)                                                                                                                                                                           
                      File "/cvmfs/dunedaq.opensciencegrid.org/spack/externals/ext-v2.1/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-12.1.0/python-3.10.10-gcsatsf5lmzrhmprzux7uv67w2omc7e3/lib/python3.10/asyncio/base_events.py",  
                    line 649, in run_until_complete                                                                                                                                                                                        
                        return future.result()                                                                                                                                                                                             
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/unified_shell/commands.py", line 44, in boot                                                                                                   
                        async for result in results:                                                                                                                                                                                       
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/process_manager/process_manager_driver.py", line 177, in boot                                                                                  
                        async for br in self._convert_oks_to_boot_request(                                                                                                                                                                 
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/process_manager/process_manager_driver.py", line 165, in _convert_oks_to_boot_request                                                          
                        self.controller_address = get_controller_address(session_dal, session)                                                                                                                                             
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/process_manager/process_manager_driver.py", line 162, in get_controller_address                                                                
                        ip = resolve_localhost_and_127_ip_to_network_ip(session_dal.segment.controller.runs_on.runs_on.id)                                                                                                                 
                      File "/nfs/home/aoranday/NFD_DEV_241021_A9/sourcecode/drunc/src/drunc/utils/utils.py", line 178, in resolve_localhost_and_127_ip_to_network_ip                                                                       
                        if ip_match.group(0).startswith('127.'):                                                                                                                                                                           
                    AttributeError: 'NoneType' object has no attribute 'group'

While trying to debug, I saw that address had the value np04-srv-024 and that ip_match == None is expected.

@aeoranday aeoranday added the bug Something isn't working label Oct 21, 2024
@aeoranday
Copy link
Member Author

By adding an edge case

if 'np04-srv-' in address or 'np02-srv-' in address:
	return address

I was able to move on, but it is not clear to me that this is the best solution or one that works in all cases.

@plasorak
Copy link
Collaborator

Fixed, via #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants