Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKS: Change TriggerSourceModel so it inherits from DataSubscriberModel and overrides handle_payload #281

Closed
ArturSztuc opened this issue Mar 7, 2024 · 1 comment · Fixed by #362
Closed

OKS: Change TriggerSourceModel so it inherits from DataSubscriberModel and overrides handle_payload #281

ArturSztuc opened this issue Mar 7, 2024 · 1 comment · Fixed by #362

Comments

@ArturSztuc
Copy link
Contributor

As explained in #280, trigger::TriggerSourceModel class should inherit from readoutlibs::DataSubscriberModel and override readoutlibs::DataSubscriberModel::handle_payload function rather than copy-pasting the entire class.

Originally posted by @glehmannmiotto in #280 (review)
@ArturSztuc
Copy link
Contributor Author

This issue will be resolved with the pending PR: #362

@ArturSztuc ArturSztuc linked a pull request Nov 18, 2024 that will close this issue
DataHandlingModel with IDT #362
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataHandlingModel with IDT DUNE-DAQ/trigger
1 participant
@ArturSztuc