Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigureAwait(false) in asp.net _core_ not needed #68

Open
rocklan opened this issue Mar 21, 2021 · 0 comments
Open

ConfigureAwait(false) in asp.net _core_ not needed #68

rocklan opened this issue Mar 21, 2021 · 0 comments

Comments

@rocklan
Copy link

rocklan commented Mar 21, 2021

Great library by the way! Super helpful! Thank you so much :)

Just a small thing BTW, Step 3 of the implementation documentation says:

To avoid performance degradation and possible dead-locks in ASP.NET or WPF applications (or any SynchronizationContext-dependent environment), you should always put ConfigureAwait(false) in your await statements

Apaprently in asp.net core this is no longer needed:

https://blog.stephencleary.com/2017/03/aspnetcore-synchronization-context.html

It won't do any harm, but it might be useful to note that this is only necessary in aspnet framework or wpf apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant