Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate code in graphQL type mapping #1068

Open
echauchot opened this issue Feb 26, 2025 · 0 comments
Open

Deduplicate code in graphQL type mapping #1068

echauchot opened this issue Feb 26, 2025 · 0 comments
Assignees
@echauchot
Labels
technical-debt

Comments

@echauchot
Copy link
Contributor

echauchot commented Feb 26, 2025 •
edited
Loading

  • GraphqlSchemaUtil#getGraphQLInputType and GraphqlSchemaUtil#getInOutType are very similar and need deduplication: if possible GraphqlSchemaUtil#getInOutType should be used for both input and output types with the correct cast and GraphqlSchemaUtil#getGraphQLInputType should be suppressed.

  • GraphqlSchemaUtil#getInOutType is creating output type whereas the method is generic for both input and output types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echauchot echauchot

Labels
technical-debt
Projects
DataSQRL
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echauchot