Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing upload-agent, the dependencies should automatically be installed #2

Open
aroder opened this issue Feb 6, 2021 · 1 comment
Assignees

Comments

@aroder
Copy link
Contributor

aroder commented Feb 6, 2021

Requirements

When installing the upload agent, its dependencies should automatically be installed. The person installing should not have to install the dependencies with a second command

The install_requires configuration option in setup.cfg is supposed to automatically install the listed dependencies. It must not be set up correctly, because installing the package and then trying to run it complains about missing dependencies

Adjust the settings so that the dependencies automatically install.

To test this behavior, in a new venv, run pip install datateer-upload-agent and then try to run datateer --help. You will get an error about a missing dependency.

You should also be able to install locally and get the same results with pip install <path-to-upload-agent-repo> and datateer --help (that way you don't have to mess with pypi just to test this issue)

Acceptance Criteria

  • Create a venv separate from the one you use to develop the project
  • Run pip install <path>
  • Run datateer --help
  • Verify that the help message is shown, and that no error occurs
@klassenjr
Copy link
Contributor

This was completed by Adam and I on 2/12. Adam I can't recall if we had any changes after the code for release 3, can you let me know if you think we have anything left to do here please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants