Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting notifications sometimes still show up when Rofi comes back #8

Open
cvincent opened this issue Nov 24, 2020 · 1 comment
Open

Comments

@cvincent
Copy link

Almost certainly a race condition. Hitting Delete to remove a notification removes that notification and then shows the Rofi window again. But sometimes the notification I just deleted still appears in the list when the Rofi window reappears. In this situation, if I Esc out of Rofi and pop Rofication up again, the notification I deleted is no longer showing. This to me indicates a race condition.

A possible solution might be to save the ID of the most recently deleted notification, and always exclude that ID when showing the current list. This approach is optimistic that the notification system received and processed the delete request, but pessimistic that the operation completed by the time the Rofi UI was redisplayed.

@DaveDavenport
Copy link
Owner

DaveDavenport commented Nov 24, 2020

I think a fix is trivial to do, rofication-gui.py should not create a second connection to send the delete, but use the existing connection.. making sure it is serialized.

edit: looking at the code after many years, this thing needs to be rewritten 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants