Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evil users may induce unbounded WAL growth (maybe?) #13

Open
DavidBuchanan314 opened this issue Nov 16, 2024 · 0 comments
Open

evil users may induce unbounded WAL growth (maybe?) #13

DavidBuchanan314 opened this issue Nov 16, 2024 · 0 comments

Comments

@DavidBuchanan314
Copy link
Owner

An unauthenticated user may trigger a long-running read of an isolated db snapshot (e.g. by calling getRepo on a large repo and reading the response very slowly).

While this is happening, writes from authenticated users (e.g. applyWrites, uploadBlob) will queue up in the WAL.

This is fine, as long as the WAL doesn't get too big. Evil authenticated users can fill up the disk through e.g. uploadBlob anyway.

Worst-case, we could detect the WAL getting too big and force a restart of the whole server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant