Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other mods that add ores #2

Open
Redd56 opened this issue Jul 14, 2021 · 3 comments
Open

Add support for other mods that add ores #2

Redd56 opened this issue Jul 14, 2021 · 3 comments
Labels
feature New feature or request

Comments

@Redd56
Copy link

Redd56 commented Jul 14, 2021

leaving this here for both me and you to see as i might just work on it myself but there are a few mods that add stones like granite/andesite etc (promenade comes to mind with its blueite and carbinite) and i think it would be great to intigrate these in. and if your new to modding dont worry its not hard to detect a mod, in mine we just use if(!FabricLoader.getInstance().isModLoaded(mod_id)){ code here } where mod_id is the namespace of the mod (universal_ores minecraft promenade etc)
also for modularity in my mod we make each mod intigration a seperate class instead of throwing it in the the primary class, i can help with that as well

@Redd56
Copy link
Author

Redd56 commented Jul 14, 2021

i just noticed this is in dawn team, so you guys prolly know way more than me, should of looked at the repo owner, so yall prolly dont need much help

@Hugman76
Copy link
Member

Thanks for the suggestion! We already have compatibility with other mods planned, textures are just not ready yet. We want to make sure everything works right and it needs more than simply this line of code. The new yet optional models, blockstates, recipes, loot tables, advancements and tags also need to be dynamically loaded. We already have found a library to help us with - that. We use it for Promenade and its compatibility with Columns.

@Redd56
Copy link
Author

Redd56 commented Jul 14, 2021

oh yeah for those i just use arrp as well. its nice that it exists, just cant figure out how to use the blockstates blockmodels or itemmodels, still need help figuring it out

@Hugman76 Hugman76 moved this to 📜 Todo in Main Project Oct 12, 2021
@Hugman76 Hugman76 added request feature New feature or request and removed request labels Oct 12, 2021
@Hugman76 Hugman76 changed the title feature: mod support Mod support Oct 12, 2021
@Hugman76 Hugman76 changed the title Mod support Add support for other mods that add ores Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: 📜 Todo
Development

No branches or pull requests

2 participants