Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sediment model hydrological forcing data #538

Open
vers-w opened this issue Jan 29, 2025 · 0 comments
Open

Sediment model hydrological forcing data #538

vers-w opened this issue Jan 29, 2025 · 0 comments

Comments

@vers-w
Copy link
Collaborator

vers-w commented Jan 29, 2025

Feature type

Changing existing functionality

Improvement Description

Hydrological forcing data in model type sediment is stored as part of the SoilLoss, OverlandFlowSediment and RiverSediment components, independently. In commit 8b38fb2 this data is now shared (in memory) between the SoilLoss and OverlandFlowSediment components. The same hydrological forcing time series are also present in the sbm and sbm_gwf model types stored at different internal model locations, compared to the sediment model. Because of this two different mappings (between the standard name and internal model name) are required.

Possible improvements:

  • Store hydrological forcing data at one location in the sediment model (two mappings are required).
  • Share the hydrological forcing data for SoilLoss and OverlandFlowSediment components (commit 8b38fb2, two mappings are required).
  • Store the hydrological forcing data at the same internal model locations as the sbm and sbm_gwf models. One mapping is required and is likely most future-proof (e.g. run sbm and sediment in a combined wflow simulation).

Implementation Description

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant