-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
identicalness for hydromt_delft3dfm #219
Comments
We needed to compare grids in imod-python, what exactly is going wrong? There's a not a lot of info in the linked issue. |
@xldeltares and I created this grid on a Friday afternoon before a holiday. The description is a bit meager I agree, but will be updated once we know more. Something happened in hydromt_delft3dfm when adding a UgridArray (variable) to an existing UgridDataset. The UgridArray did not have all dimensions that the UgridDataset has, so we created a xugrid branch/PR with the old compare function to test if it worked. This was the case, but three xugrid testcases failed and further investigation is necessary on our side. This is the related issue, but it also lacks description for now: Deltares/hydromt_delft3dfm#128. An update will follow in a few weeks. |
Resolved externally in Deltares/hydromt#848 and then in Deltares/hydromt_delft3dfm#129. This issue can therefore be closed as it is in the wrong repos. |
Related to Deltares/hydromt_delft3dfm#128
xugrid/ugrid/ugridbase.py >> equals has changed from 0.8.1 to 0.9.0
causes errors when adding ugriddatararray to existing ugriddataset if not equal
xugrid/ugrid/ugridbase.py
0.8.1:
0.9.0:
The text was updated successfully, but these errors were encountered: