New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SetControlToon #314

Open

AlgarDude opened this issue Dec 22, 2024 · 0 comments

Labels

refactor

Collaborator

AlgarDude commented Dec 22, 2024

Temporarily disabled initial portion as we were returning before we iterated over the OAL.

Refactor to use cascading priority
OAL > Group MA Role > Me (fallback)

Get rid MA being set in init (initializes to Me and then we use Group MA if present), or call SetControlToon in its place

Additional considerations:

Should we have fallback if the MA is dead?
Should we have a textbox where we specify the MA and get rid of this logic? (The OAL becomes an outside heal list at this point)
Should we add the raid MA role in there?

AlgarDude added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment