From 306886c888d3f7cbebf373e804273a97b8856c01 Mon Sep 17 00:00:00 2001
From: overthestream <njhnjh02@naver.com>
Date: Tue, 9 Jan 2024 17:06:35 +0100
Subject: [PATCH] Refactor getBlurtingNo method in BlurtingController and
 BlurtingService

This commit refactors the `getBlurtingNo` method in the `BlurtingController` and `BlurtingService` files. The changes include removing unnecessary code, improving code readability, and fixing a bug related to checking if a user has liked a post.
---
 src/blurting/blurting.controller.ts | 26 +++++++++-----------------
 src/blurting/blurting.service.ts    |  5 +----
 2 files changed, 10 insertions(+), 21 deletions(-)

diff --git a/src/blurting/blurting.controller.ts b/src/blurting/blurting.controller.ts
index 014d9cc..aa0ccd6 100644
--- a/src/blurting/blurting.controller.ts
+++ b/src/blurting/blurting.controller.ts
@@ -8,6 +8,7 @@ import {
   Body,
   Param,
   Put,
+  NotFoundException,
 } from '@nestjs/common';
 import { Request, Response } from 'express';
 import { BlurtingService } from './blurting.service';
@@ -273,24 +274,15 @@ export class BlurtingController {
     description: '선택 Q&A 정보 반환',
     type: BlurtingPageDto,
   })
-  async getBlurtingNo(
-    @Req() req: Request,
-    @Param('no') no: number,
-    @Res() res: Response,
-  ) {
+  async getBlurtingNo(@Req() req: Request, @Param('no') no: number) {
     const { id } = req.user as JwtPayload;
     const user = await this.userService.findUserByVal('id', id);
-    if (user.group == null) return res.sendStatus(404);
-    try {
-      const blurtingPage = await this.blurtingService.getBlurting(
-        id,
-        user.group,
-        no,
-      );
-      return res.json(blurtingPage);
-    } catch (error) {
-      console.log(error);
-      return res.status(error.status).json(error);
-    }
+    if (user.group == null) throw new NotFoundException();
+    const blurtingPage = await this.blurtingService.getBlurting(
+      id,
+      user.group,
+      no,
+    );
+    return blurtingPage;
   }
 }
diff --git a/src/blurting/blurting.service.ts b/src/blurting/blurting.service.ts
index 96946c7..767df5f 100644
--- a/src/blurting/blurting.service.ts
+++ b/src/blurting/blurting.service.ts
@@ -186,10 +186,8 @@ export class BlurtingService {
             },
           },
         });
-
         let iLike = false;
-        if (likes.filter((item) => item.userId === user.id).length > 0)
-          iLike = true;
+        if (likes.filter((item) => item.userId === id).length > 0) iLike = true;
 
         if (answerEntity.user == null) {
           return BlurtingAnswerDto.ToDto(
@@ -219,7 +217,6 @@ export class BlurtingService {
         );
       }),
     );
-
     const blurtingPage: BlurtingPageDto = BlurtingPageDto.ToDto(
       group,
       question,